Discussion:
[rtems commit] tod.h -> libcsupport like other driver and helper prototype files
Sebastian Huber
2014-09-18 09:19:17 UTC
Permalink
.../libcsupport/include/rtems}/tod.h | 3 +--
I don't think this is the right location for this header file. The API
declared in this header file is highly questionable since it circumvents the
device file layer. This change breaks also all applications that used this
file via #include <tod.h> or #include <bsp/tod.h>.
--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber-L1vi/***@public.gmane.org
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
Joel Sherrill
2014-09-18 12:37:26 UTC
Permalink
Post by Sebastian Huber
.../libcsupport/include/rtems}/tod.h | 3 +--
I don't think this is the right location for this header file. The API
declared in this header file is highly questionable since it
circumvents the
device file layer. This change breaks also all applications that used this
file via #include <tod.h> or #include <bsp/tod.h>.
The API and implementation are ancient. I don't have time nor inclination to redesign or reimplement them. Is there even a standard way to do this? But...

I don't mind moving this (and other files in that include directory) to more appropriate source and install tree locations though. There are at least a handful of files which IMO are incorrectly placed under libcsupport.
Sebastian Huber
2014-09-18 12:40:53 UTC
Permalink
Post by Joel Sherrill
Post by Sebastian Huber
.../libcsupport/include/rtems}/tod.h | 3 +--
I don't think this is the right location for this header file. The API
declared in this header file is highly questionable since it
circumvents the
device file layer. This change breaks also all applications that used this
file via #include <tod.h> or #include <bsp/tod.h>.
The API and implementation are ancient. I don't have time nor inclination to redesign or reimplement them. Is there even a standard way to do this? But...
I don't mind moving this (and other files in that include directory) to more appropriate source and install tree locations though. There are at least a handful of files which IMO are incorrectly placed under libcsupport.
I think we should keep this low quality stuff out of cpukit. So maybe place it
in <libchip/tod.h>.
--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : ***@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
Loading...